search

ucsdlib / damsrepo

DAMS Repository
Other
4 stars 2 forks source link

Release 4.42 #81

Closed gamontoya closed 5 years ago

gamontoya commented 5 years ago

Descriptive Summary

gamontoya commented 5 years ago

@lsitu Feel free to ask Ron or John to deploy Tuesday morning today since you'll be out for Code4Lib next week.

lsitu commented 5 years ago

@gamontoya / @hjsyoo I've deployed release 4.42 to staging. It's ready for review now. Could we review the above two ticket by testing the mint DOI function and the update DOI function? Thanks.

gamontoya commented 5 years ago

@hjsyoo Are you able to test minting DOIs and updating them on the staging environment?

hjsyoo commented 5 years ago

@remerjohnson To properly test this deploy, we'll need a couple of RDF edits in staging. Can you add a dummy Preferred Citation (with no DOI) and Date:Issued (if missing) to these objects: Scripps CO2: https://librarytest.ucsd.edu/dc/object/bb32791536 CalCOFI: https://librarytest.ucsd.edu/dc/object/bb6213315c CCDB: https://librarytest.ucsd.edu/dc/object/bb0753405q You can use this template for the citations: [Any one author of this object]. (2019). [Object title]. UCSDL DC.

gamontoya commented 5 years ago

@remerjohnson @hjsyoo Let me know when this testing is done. I can't push this to production until I get confirmation you tested and it's working.

remerjohnson commented 5 years ago

@gamontoya Gotcha. I am unable to log in to staging DAMSManager at the moment on either of my browsers...

Update: getting on the VPN worked

hjsyoo commented 5 years ago

@gamontoya Testing now. Do we need to do an RDF edit before I update the DOI record? Or can I just push the button? I'm wondering if the Update function first looks for changes, or if it just pushes the metadata again. If it's the latter, we probably don't need to edit anything?

gamontoya commented 5 years ago

@hjsyoo I have no idea. Try both.

hjsyoo commented 5 years ago

@gamontoya @remerjohnson It looks like the fix now generates expected behavior! The testing followed this sequence:

  1. Ryan added required fields to the 3 objects
  2. I clicked on Mint DOI and took screenshots of the EZID records, obj pages, and coll pages.
  3. Ryan edited 2 of the objects
  4. I clicked on Update DOI record and took screenshots of the EZID records, obj pages, and coll pages.

The collection pages remained identical before and after updates were applied. Object pages retained their metadata, except that Date order sometimes switched after an update. This is fully expected.

I did notice that the Subject:Anatomy values aren't getting pushed to EZID. I think this is a bug, but I'll create a ticket later, after conferring with DOMM.

gamontoya commented 5 years ago

@hjsyoo @remerjohnson Let's check things tomorrow morning after a full nightly re-index.

gamontoya commented 5 years ago

@lsitu Let's go ahead and push to production.

@hjsyoo @remerjohnson I assume you checked this morning (stage) and all looks good.

lsitu commented 5 years ago

@rstanonik The changes for Release 4.42 for damsrepo is in the master branch already. So we are ready to move it to prod now. Could you deploy it tomorrow morning during your regular deployment window? I think we just need to restart tomcat on lib-hydratail-prod after you deploy it. Thank you.

rstanonik commented 5 years ago

damsrepo deployed to prod this morning and the tomcat was restarted

lsitu commented 5 years ago

Thanks @rstanonik .

gamontoya commented 5 years ago

Kamino cloned this issue to ucsdlib/damsrepo