search

ucsdlib / damsrepo

DAMS Repository
Other
4 stars 2 forks source link

Update DOI function throws an error when geoLocationPoint data is present #87

Closed hjsyoo closed 5 years ago

hjsyoo commented 5 years ago

Descriptive summary

When I try to mint or update a DOI record on an object with geoLocationPoint data, I get the following error:

Error updating DOI: error: bad request - datacite: metadata validation error: Element '{http://datacite.org/schema/kernel-4}geoLocationPoint': Character content other than whitespace is not allowed because the content type is 'element-only'., line 47

For example, https://library.ucsd.edu/dc/object/bb6930466p has point data and an existing DOI. When pushing the Update DOI Record button, I get the error above. Note that the EZID record, https://ezid.cdlib.org/id/doi:10.6075/J01V5BW2, currently has the point data because it was manually entered at the time of the original minting. I can't seem to update it now.

Related work

https://github.com/ucsdlib/damsrepo/issues/74.

hjsyoo commented 5 years ago

@gamontoya This work is high priority for RDCP, but I removed the label because I don't remember how exactly we are using it.

gamontoya commented 5 years ago

@VivianChu Something for you to work on after UC DLFx and the long weekend.

VivianChu commented 5 years ago

@hjsyoo @gamontoya - The fix has been deployed to staging.
Could you review it? https://librarytest.ucsd.edu/dc/object/bb6930466p Here are the screen shot. Thanks Before the fix

beforeFixGeoPointError

After the fix

afterFixGeoPoint

ezid

gamontoya commented 5 years ago

@VivianChu Looks good on staging!

hjsyoo commented 5 years ago

@VivianChu Agreed, it looks good! Thank you.

VivianChu commented 5 years ago

Thanks @gamontoya @hjsyoo for reviewing. Currently I'm waiting for the change to get reviewed and merged into the code base. Whenever it gets merged, I'll create a new release for production.

VivianChu commented 5 years ago

@hjsyoo @gamontoya - It works fine in production for me. https://library.ucsd.edu/dc/object/bb6930466p