search

ucsdlib / heaven

:walking: Rails app for GitHub Flow
MIT License
0 stars 0 forks source link

R&D: Switch to bundler capistrano provider #2

Open mcritchlow opened 5 years ago

mcritchlow commented 5 years ago

https://github.com/atmos/heaven/blob/master/doc/providers.md#bundler-capistrano

As far as I can tell, changing our provider from capistrano to bundler_capistrano and make the environment variable change (if needed) in each project might alleviate the issue I've been concerned about which is every app getting deployed with the same capistrano environment. It looks like the other change we might need to make is moving some gems around to deployment and/or heaven Gemfile groups.

@VivianChu - could you let me know what you think about this whenever you have a chance?

VivianChu commented 5 years ago

@mcritchlow - That sounds good. From the doc above, it mentions

In your Capfile, you'll need to add:

set :branch, (ENV['BRANCH'] || fetch(:branch, 'master'))

Currently for dmr, we have that line for each of environment deploy config files - https://github.com/ucsdlib/dmr/blob/master/config/deploy/production.rb#L3 https://github.com/ucsdlib/dmr/blob/master/config/deploy/staging.rb#L3 If we switch it bundler capistrano provider, does that mean we don't need it for each environment deploy config file? Do you want me to work on it for this Sprint? Or wait after hifive app get deployed to production?

mcritchlow commented 5 years ago

@VivianChu - Yeah we might, I'm not sure. I think the nice thing is we could pick just one project to try this out on, since each app in the apps.json files specifies it's provider separately. So maybe not hifive right now, since as you said we're about to go to prod. But maybe a different one, or H5 next week?

VivianChu commented 5 years ago

@mcritchlow - We can try H5 and DMR next week.