ucsdlib / hifive

An application supporting an Employee Recognition program workflow
MIT License
0 stars 0 forks source link

Consoliate Dockerfiles into one using target builds, update docker-co… #305

Closed ecliptik closed 4 years ago

ecliptik commented 4 years ago

…mpose files to use targets

Fixes #299

Local Checklist

What does this PR do?

Consolidates Dockerfiles into single Dockerfile using Docker Target Builds

Development build example,

docker build -t hifive:development --target development .

Production build example,

docker build -t hifive:production --target production .
Why are we doing this? Any context of related work?

References #299

Where should a reviewer start?

Use the bin/docker-helper.sh to test building with new Dockerfile and updated compose files.

Manual testing steps?

Screenshots

NONE

Database changes

NONE

New ENV variables

NONE

Deployment Instructions

Relevant docker-compose files updated to point to new target. Builds locally successfully, althoug production builds give a Missing encryption key to decrypt file with. Ask your team for your master key and write it to /home/theodor/app/config/master.key or put it in the ENV['RAILS_MASTER_KEY']. error.

@ucsdlib/developers - please review

mcritchlow commented 4 years ago

Thanks for the PR, but we're going to have someone on our team work on this.