Extract ActionMailer delivery/host to env vars - Githubissues

ucsdlib / hifive

An application supporting an Employee Recognition program workflow

MIT License

0 stars 0 forks source link

Extract ActionMailer delivery/host to env vars #323

Closed mcritchlow closed 5 years ago

mcritchlow commented 5 years ago

Fixes #322

Also see: https://github.com/ucsdlib/env-variables/pull/99 which sets up these values for staging/production

Local Checklist

[x] Tests written and passing locally?
[x] Code style checked?
[x] QA-ed locally?
[x] Rebased with master branch?
[ ] Configuration updated (if needed)?
[ ] Documentation updated (if needed)?

What does this PR do?

Add APPS_H5_EMAIL_HOST and APPS_H5_DELIVERY_METHOD env vars
Add a .env.test file for the test versions of these values
Remove individual instances of these hard-coded values from the environment config files
Add the config setup in config/application.rb, which enforces that these new variables are always present

Why are we doing this? Any context of related work?

References #301

@ucsdlib/developers - please review