ucsf-education / moodle-admin-tool-ldapsync

A Moodle admin tool for importing users from LDAP server.
GNU General Public License v3.0
1 stars 2 forks source link

Failed unit test: core\adminlib_test::test_admin_output_new_settings_by_page #12

Closed ctam closed 4 months ago

ctam commented 6 months ago

Failed unit test when integrated with Moodle 4.3

core\adminlib_test::test_admin_output_new_settings_by_page
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
-Array &0 ()
+Array &0 (
+    'ldapsync_settings' => '-->New settings - Settings\n
+<fieldset class="adminsettings">\n
+<div class="clearer"><!-- --></div>\n
+<div class="form-item row" id="admin-authtype">\n
+    <div class="form-label col-sm-3 text-sm-right">\n
+            <label for="id_s_tool_ldapsync_authtype">\n
+                Auth type\n
+            </label>\n
+        <span class="form-shortname d-block small text-muted">tool_ldapsync | authtype</span>\n
+    </div>\n
+    <div class="form-setting col-sm-9">\n
+        <div class="form-select defaultsnext">\n
+    <select  id="id_s_tool_ldapsync_authtype" name="s_tool_ldapsync_authtype" class="custom-select">\n
+            <option value="manual" >manual</option>\n
+            <option value="email" >email</option>\n
+    </select>\n
+</div>\n
+        <div class="form-description mt-3"><p>Select the authentication type for the imported accounts.</p>\n
+</div>\n
+        \n
+    </div>\n
+</div></fieldset>'
+)

/home/runner/work/moodle/moodle/lib/tests/adminlib_test.php:151
/home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:81
ctam commented 4 months ago

Fixed by commit 0923859.