Addresses overly optimistic wind capacity factor issue

ucsusa / pypsa-illinois

A model of the Illinois electricity system built with PyPSA.

GNU General Public License v3.0

4 stars 0 forks source link

Addresses overly optimistic wind capacity factor issue #36

Closed samgdotson closed 2 months ago

samgdotson commented 2 months ago

[!IMPORTANT] This PR should be reviewed after #34 has been merged.

This PR closes #35 by adding a parameter to the config.yml file called capacity_factor. The add_electricity rule modifies the wind availability time series by renormalizing to the capacity_factor value.

pep8speaks commented 2 months ago

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file scripts/add_electricity.py:

Line 463:80: E501 line too long (86 > 79 characters)

In the file scripts/retrieve_costs.py:

Line 7:1: E402 module level import not at top of file

Comment last updated at 2024-09-03 14:34:03 UTC

samgdotson commented 2 months ago

@ssattler if you're satisfied with the changes in this pull request, would you mind hitting the big green "merge pull request" button? In general, it's best practice for somebody else (besides the person making the PR) to merge a pull request.

For chronological reasons, this PR needs to be merged after #35. PRs are listed newest to oldest by default, so this one appears to be "first" on the list. Thanks!