search

ucupumar / ucupaint

Ucupaint is Blender addon to manage texture layers for Eevee and Cycles renderer.
GNU General Public License v3.0
1.24k stars 37 forks source link

Refactor version functions #174

Closed passivestar closed 5 days ago

passivestar commented 6 days ago

Use generic functions to check for blender and data versions

passivestar commented 5 days ago

Rebased on master and fixed 2.80, pls test with old blender because I'm not sure if old python supports optional params

passivestar commented 5 days ago

is_created_using() actually was unused :)

passivestar commented 5 days ago

I should probably also swap all of these for tuple literals, there's no need to parse them from strings

image
ucupumar commented 5 days ago

Oh yeah, of course 😁 Anything else need to change before merging?

passivestar commented 5 days ago

Anything else need to change before merging?

I just tested in the latest blender and in 2.80 by adding different layers, didn't get any errors in the console. If all looks good to you I think this should be good to go now

ucupumar commented 5 days ago

Okay, I'm merging it now. Thanks for the PR! 👍