search

udacity / AdvancedAndroid_Emojify

139 stars 452 forks source link

source code outdated #56

Open johnjeremih opened 4 years ago

johnjeremih commented 4 years ago

I'm asking for permission to update this source code. Can I submit a pull request?

mahmood-ghaem commented 4 years ago

Hi, I have problem in this line in MainActivity.java: Uri photoURI = FileProvider.getUriForFile(this, FILE_PROVIDER_AUTHORITY, photoFile);

I updated the code of the first lesson Android_Me and rewrote, but I had a lot of trouble with this lesson in this source he used android.support.v4 and i have to convert to androidx but does not work.

johnjeremih commented 4 years ago

Hi, I have problem in this line in MainActivity.java: Uri photoURI = FileProvider.getUriForFile(this, FILE_PROVIDER_AUTHORITY, photoFile);

I updated the code of the first lesson Android_Me and rewrote, but I had a lot of trouble with this lesson in this source he used android.support.v4 and i have to convert to androidx but does not work.

can you please send a screenshot of the error?

mahmood-ghaem commented 4 years ago

Hi, I have problem in this line in MainActivity.java: Uri photoURI = FileProvider.getUriForFile(this, FILE_PROVIDER_AUTHORITY, photoFile); I updated the code of the first lesson Android_Me and rewrote, but I had a lot of trouble with this lesson in this source he used android.support.v4 and i have to convert to androidx but does not work.

can you please send a screenshot of the error?

I corrected that error but app doesn't work. you can see in my fork: this link thanks.

johnjeremih commented 4 years ago

You erased the Gradle and the app module

Screen Shot 2020-04-15 at 9 14 51 PM
mahmood-ghaem commented 4 years ago

You erased the Gradle and the app module

I published again AdvancedAndroid_Emojify run correctly i also test that in a real mobile phone instead emulator but after take picture that's crash.

I usually delete these files and folders before push a project to the repo. Isn't that right?

--------------------------project folder .gradle/ .idea/ .gitignore Project_Name.iml local.properties --------------------------app folder build/ libs/ .gitignore proguard-rules.pro --------------------------src folder androidTest/ test/

I'm new in GitHub can you see my projects and send me your feedback, please. This is my Email.

johnjeremih commented 4 years ago

Those are crucial files. The only file that you should delete are those where you put your API key or tokens

mahmood-ghaem commented 4 years ago

Those are crucial files. The only file that you should delete are those where you put your API key or tokens

i saw https://github.com/google-developer-training/android-fundamentals-apps-v2

they also delete some folder and files

Sagar0-0 commented 2 years ago

62 Here have a look at this, I migrated this project to androidx and latest dependency versions with all issue resolved.