search

udacity / AdvancedAndroid_Shushme

136 stars 367 forks source link

Ringer mode issues #2

Open gaelmarhic opened 7 years ago

gaelmarhic commented 7 years ago

Hi!

When trying this solution final code on my phone (running with Android N), I ran into some issues which made the app crash:

1) Some packages in the GeofenceBroadcastReceiver file have not been imported, so that it does not let compile.

2) The permission for the ACCESS NOTIFICATION POLICY is not present in the Manifest.xml file.

3) Since when we want to change the Ringer mode we want to make sure that Notification Policy Access is granted (in case our SDK is 24 or greater), I think the appropriate code should be:

if (android.os.Build.VERSION.SDK_INT < 24 || (android.os.Build.VERSION.SDK_INT >= 24 && nm.isNotificationPolicyAccessGranted())) ...

and not if (android.os.Build.VERSION.SDK_INT < 24 || (android.os.Build.VERSION.SDK_INT >= 24 && !nm.isNotificationPolicyAccessGranted())) ...

I actually removed the "!", since in the current version of the code we try to change the Ringer mode status when the permission is not granted...

Thanks for your great tutorials guys!

Kind regards,

Gaël

dharanad commented 7 years ago

Add <uses-permission android:name="android.permission.ACCESS_NOTIFICATION_POLICY"/> in the manifest file.

hrishikesh-kadam commented 6 years ago

All bugs fixed in - https://github.com/udacity/AdvancedAndroid_Shushme/pull/12

moharidy commented 6 years ago

thanks all but i still have an issue with the ringer issue, when the geofences switch is disabled the silent mode does not get disabled and the phone still continue on silent mode? any suggestion ?