fix: Could NOT find OpenSSL problem in install-mac.sh

udacity / CarND-Kidnapped-Vehicle-Project

MIT License

121 stars 1.3k forks source link

fix: Could NOT find OpenSSL problem in install-mac.sh #22

Closed kevguy closed 6 years ago

kevguy commented 7 years ago

install-mac.sh script will fail in building uWebSockets if OPENSSL_ROOT_DIR is not set.

Reference: link

tsekityam commented 7 years ago

Looks like the pull request is based on your working branch, and you have pushed many things to the branch after creating this request. As a result, this request involves more than 2000 file changes.

By the way, I think this pull request is a duplicate of #18 , although your fix is diff to his.

mvirgo commented 6 years ago

Closing out due to this seeming to include a lot of other observation files from your own working branch. Feel free to submit a new pull request just specific to the issues above if you'd like.