search

udacity / CarND-Term1-Starter-Kit

MIT License
494 stars 602 forks source link

docker instructions #3

Closed giladgressel closed 7 years ago

giladgressel commented 7 years ago

@joshuacook should take a look at those more carefully. We started a document for this actually.

I think the first command you list is not needed, and the second has one syntax error , the pwd needs to be {pwd}

here is the link to the doc we have working on this. https://codeshare.io/axLBda

joshuacook commented 7 years ago

Looks like I wrote those or am the maintainer ...

joshuacook commented 7 years ago

These are not good docker instructions. Our students should never be using bash on their container. @domluna are you on slack where we can chat about this?

giladgressel commented 7 years ago

please pipe me into it, when/wherever it starts. @joshuacook can't you just replace this docker file with the one you had me running?

giladgressel commented 7 years ago

@yrahal Just alerting you to this repo. We are building a start-kit for the Term1 of SDC. I saw your medium post about your docker container, perhaps you'd like to help debug and contribute to this? This will be the official repo/readme for the course when we are done. thanks!

joshuacook commented 7 years ago

yes

joshuacook commented 7 years ago

Didn't mean to be harsh. Just I put a ton of work into this like three weeks ago. It looks like it was pulled from here: https://github.com/joshuacook/CarND-TensorFlow-L2

It should be but it also needs run_jupyter.sh

domluna commented 7 years ago

@joshuacook same name on Slack. Yeah the Dockerfile was pulled from the udacity/CarND-TensorFlow-L2 repo. I took out the jupyter part out because it seemed project specific but I could be wrong. For example the Behavioural cloning project doesn't use Jupyter at all.

joshuacook commented 7 years ago

I don't think we are on any shared slack teams.

domluna commented 7 years ago

Yeah just realised that ...

joshuacook commented 7 years ago

mlnd, nd889, carnd, ...

domluna commented 7 years ago

Does #9 solve this?

giladgressel commented 7 years ago

Yes I think so, except only for windows 10..... we still need to edit more for windows 8, where the tools aren't the same perhaps an entirely new page is the way to go though

joshuacook commented 7 years ago

My understanding is that windows !10 uses Docker Toolbox which I think is bash and therefore just like mac/linux. I still think we should have a totally separate page.