search

udacity / DSND_Term2

Contains files related to content and project of DSND Term 2
MIT License
1.1k stars 1.66k forks source link

Error in "How to break into the field" notebook #14

Closed ltirrell closed 3 years ago

ltirrell commented 4 years ago

In question 3 of this notebook, the docstring says: return 1 if the string is in ("Master's degree", "Doctoral", "Professional degree"). However, Doctoral is not one of the values in formal education:

>>> pd.unique(df.FormalEducation)
    array(['Secondary school',
       "Some college/university study without earning a bachelor's degree",
       "Bachelor's degree", 'Doctoral degree', "Master's degree",
       'Professional degree', 'Primary/elementary school',
       'I prefer not to answer', 'I never completed any formal education'],
      dtype=object)

This leads to a change in results, which doesn't seem to effect question 5. However, the group which suggests certain methods more changes in some cases issue

ronny-udacity commented 3 years ago

Thank you for reporting the bug. It's been fixed in the classroom and GitHub repo.