search

udacity / DSND_Term2

Contains files related to content and project of DSND Term 2
MIT License
1.1k stars 1.66k forks source link

Adding chart 5 break the columns because div tag hasn't been closed #31

Closed syahrulhamdani closed 3 years ago

syahrulhamdani commented 3 years ago

When I was working on the Web Development lessons, the first div tag hasn't been closed. So it really messed up when adding chart 5.

https://github.com/udacity/DSND_Term2/blob/e84998eb9cbb3b4bbc06a47b1ff719725106359f/lessons/WebDevelopment/BackEndWorkspaceFiles/4_flask%2Bplotly%2Bpandas_exercise/worldbankapp/templates/index.html#L84

https://github.com/udacity/DSND_Term2/blob/e84998eb9cbb3b4bbc06a47b1ff719725106359f/lessons/WebDevelopment/BackEndWorkspaceFiles/4_flask%2Bplotly%2Bpandas_exercise/worldbankapp/templates/index.html#L88

ronny-udacity commented 3 years ago

Thank you for reporting the issue. It's been fixed in the classroom and GitHub repo.