udacity / RL-Quadcopter

Teach a Quadcopter How to Fly!
138 stars 108 forks source link

Please add tensorflow, keras, pytorch, etc. to the requirements.txt file #5

Open sbbogdan opened 6 years ago

sbbogdan commented 6 years ago

For the deep learning nanodegree we are going to have to use at least one, or multiple of these libraries. It makes no sense for their presence not to be in the requirements.txt file, or even mentioned anywhere in the instructions.

It would be nice if you could: a) Add an README.md step beneath 'Python Packages' that explicitly requires students to open the requirements.txt file b) Have commented out lines for popular packages like tensorflow, keras, pytorch, etc. and ask students to review what they think they will use, and then uncomment such out prior to proceeding. Realistically, hard drive space is so cheap and plentiful these days that these libraries should not be a significant space burden and it is probably just easier to include at least keras, pandas, and tensorflow by default. Students can uninstall what they don't need.

ablacklama commented 6 years ago

pandas/h5py too.

sbbogdan commented 6 years ago

+1 to pandas and h5py. Those were needed for this project.

Tensorflow can be installed with pip, that's what I did. It just won't be GPU accelerated AFAIK.

ablacklama commented 6 years ago

you're completely right. I honestly forget that cpu tensorflow even exists sometimes... I removed it from my comment