udacity / andfun-kotlin-android-trivia

Other
197 stars 481 forks source link

Fix ImageView id in fragment_game_over.xml #33

Closed chr-ibb closed 2 years ago

chr-ibb commented 3 years ago

The current id, "gameOverFragment," describes a Fragment, when it should be describing an ImageView. The proposed change, "youLoseImage," would match the id of the ImageView in the sister fragment, "youWinImage." The current id is meant to be used later in the navigation graph, which will result in a conflict or Android Studio automatically choosing the name "gameOverFragment2," which could be confusing since it doesn't match video on Udacity.

SudKul commented 2 years ago

Thanks, @chr-ibb