search

udacity / cd0581-building-a-reproducible-model-workflow-exercises

Exercise Staters and solutions for cd0581-building-a-reproducible-model-workflow by Giacomo Vianello
Other
20 stars 87 forks source link

Incorrect use of random seeds in the solution to exercise_14 #9

Open fantauzzi opened 2 years ago

fantauzzi commented 2 years ago

With reference to file https://github.com/udacity/cd0581-building-a-reproducible-model-workflow-exercises/blob/main/lesson-5-final-pipeline-release-and-deploy/exercises/exercise_14/solution/main.py

the call to the sub-project segregate omits passing the random seed, I think the call should pass it.

Also, at line 91 it is passing the wrong random seed to the random_forest sub-project. I believe it can be corrected like this

"random_seed": config['random_forest_pipeline']['random_forest']['random_state'],