search

udacity / dlnd-issue-reports

5 stars 0 forks source link

Bug in DeepFaces Unit Test #524

Closed mark5udacity closed 6 years ago

mark5udacity commented 6 years ago

Starting on line 125/126, line 126 should clearly be asserting tensor shape for g_loss, not d_loss

_assert_tensor_shape(d_loss, [], 'Discriminator Loss') _assert_tensor_shape(d_loss, [], 'Generator Loss')

lcrucks commented 6 years ago

Hi Mark,

Where precisely is this?

mark5udacity commented 6 years ago

Hey Luke,

Thanks for reaching out.

I hope the following link helps: https://github.com/udacity/deep-learning/blob/master/face_generation/problem_unittests.py#L126

On Wed, Mar 14, 2018 at 6:04 PM, Luke Rucks notifications@github.com wrote:

Hi Mark,

Where precisely is this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/udacity/dlnd-issue-reports/issues/524#issuecomment-373190442, or mute the thread https://github.com/notifications/unsubscribe-auth/AcWJWBE3s2z5lDT4ze-3fsYb9pHN23_Wks5teZP2gaJpZM4SqulI .

lcrucks commented 6 years ago

Fixed