search

udacity / frontend-grading-engine

Providing immediate feedback for front-end code
MIT License
132 stars 172 forks source link

warn students that zooming their browsers will affect test results #17

Closed cameronwp closed 7 years ago

cameronwp commented 8 years ago

I've seen some complaints that zooming prevents tests from passing, especially when tests are related to any kind of pixel calculation. Let's consider adding a feature where we warn students to stay at 100% zoom so that tests pass.

The alternative is to actually account for zoom with pixel calculations. My intuition is that this is more trouble than its worth, but I could be wrong.

notetiene commented 8 years ago

Is it related to the new version or the extension in general?

Do you have an example of the issue?

cameronwp commented 8 years ago

In general. This quiz is reported to have failed when zoomed in.

Just to be clear, this is not an urgent issue.

On Tue, Jul 19, 2016 at 1:47 PM Etienne notifications@github.com wrote:

Is it related to the new version or the extension in general?

Do you have an example of the issue?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/udacity/frontend-grading-engine/issues/17#issuecomment-233728862, or mute the thread https://github.com/notifications/unsubscribe-auth/AE8jHxnVg8FfTscTFhJJ3FGxgzQti7imks5qXRvRgaJpZM4JQAhC .

notetiene commented 8 years ago

I can't replicate the issue when zooming.

notetiene commented 7 years ago

I've tried both Chrome and Firefox in many ways and I'm unable to replicate the issue when zooming. It might have been fixed with the position fixes.