search

udacity / frontend-grading-engine

Providing immediate feedback for front-end code
MIT License
132 stars 172 forks source link

Udacity Feedback Extension not recognize font awesome icon #23

Closed kresnasatya closed 7 years ago

kresnasatya commented 7 years ago

Hi team, thanks for providing Responsive Images as a good course for me. It's a good thing that web developer should care about images, typography when develop website. When I'm using fontawesome to get facebook, twitter, google+, and digg, the Udacity feedback extension doesn't respons it (I have refresh it several times in Google Chrome browser). This is the screenshot:

responsive images feedback course

This is the Gist Code

But, when I see your project-2 solution, it use the We Love Font Icons website as the provider font icon. Why only this website can recognized by Udacity feedback extension? I think it should be fix it, so that's not only We Love Font Icons but Font awesome and other font icons website can recognized by Udacity feedback extension. Thank you very much.

P.S. I have give this issue on responsive-images repository. I give this issue on this repo to get your fast response answer.

notetiene commented 7 years ago

Since it was already reported in the responsive-images course and it's not related to the extension itself. I'm closing it.