search

udacity / frontend-nanodegree-feedreader

Other
72 stars 1.67k forks source link

Rmv invoking parens to fit jQuery callback signtr. #4

Closed prather-mcs closed 9 years ago

prather-mcs commented 9 years ago

I removed parentheses on 131, which were immediately invoking the anonymous function, which was contradicting the stated intention to use $ to invoke the code only after the ready event.

prather-mcs commented 9 years ago

And, if you want to fix an even smaller problem, change the spelling on line 115, from "occuring" to "occurring"

prather-mcs commented 9 years ago

There's the same problem over in: https://github.com/udacity/frontend-nanodegree-feedreader/blob/master/jasmine/spec/feedreader.js (erroneous parens invoking the function you pass to $)

prather-mcs commented 9 years ago

I'm closing this PR in order to create a new PR that actually uses git branches, instead of pushing to master like this PR is doing.