Confusing wording in test from task 2 - Githubissues

udacity / nd1309-p2-Decentralized-Star-Notary-Service-Starter-Code

Code for the ND1309 v2 C2 project

Other

9 stars 97 forks source link

Confusing wording in test from task 2 #13

Open samraul opened 2 years ago

samraul commented 2 years ago

https://github.com/udacity/nd1309-p2-Decentralized-Star-Notary-Service-Starter-Code/blob/ad8d65e2b0fb69737c481570eeb85953f2599936/test/TestStarNotary.js#L78-L81

This test seems to be mixing the concepts of star information vs contract information.

There is no such thing as star symbol
There is no need to create a star to check the contract name and symbol
When it asks to compare versus name and symbol provided, it does not state where they are provided.
- The properties should probably be in the constructor, so perhaps it should state so?

Thanks.

jungleBadger commented 2 years ago

Hi there, @samraul. Thanks for your concern; let me address your points below:

The star symbol is required and can be available through 02 main strategies: Hardcoded value in all Stars created by your Smart Contract or receiving it as a variable in the Constructor.
You are correct; you need to check against one created in previous steps. The students are free to create a new one if they wish to.
They are properties available in all Stars created in your Smart Contract.
As I disclaimed in point 1 above, it is not mandatory to be in the Constructor.

Finally, here is the highlight from the project's rubric disclaiming the usage of the Star symbol: