udacity / robotics-beta-test-issues

1 stars 0 forks source link

Project - Where am I - Update first rubric point #763

Closed Shreeyak closed 6 years ago

Shreeyak commented 6 years ago

The first rubric point simply mentions checking all files. It will be very helpful here to provide a list of all required files. I believe this is done in other projects?

Here's the first rubric point as it is now:

The student submitted all required files specified in the criteria.

Tip
Please make sure you first check all of the files and make sure they are present. If they are not present, do not fail the student on this point but mark the whole project as "cannot review" and explain to student what file is missing.

All images must be watermarked with the student's first and last name.
sahiljuneja commented 6 years ago

Well, since you beta-tested the project all files should have been easy to check. Also being able to run the project without issue is perhaps the easiest way to check on this, although, not sure whether that's more time consuming than checking all files or not.

There might be an update to the project repo soon which might make things easier for students and reviewers alike. Will update once that's ready and can then see if more information will be required or not around this.

Shreeyak commented 6 years ago

Yes, we don't need to check all the files inside the package. The requirements are mentioned in the rubric, under criteria: "Include in your project submission your write-up (PDF format), supporting images, and the entire ROS package you created."

Simply asking to add the same as bullet points under "meets specifications" to make it easier while reviewing. Here is the rubric, check the second point. Just doing the same for the first point would help: https://review.udacity.com/#!/rubrics/1365/view

Thanks

On Fri, Feb 23, 2018 at 9:52 PM, Sahil Juneja notifications@github.com wrote:

Well, since you beta-tested the project all files should have been easy to check. Also being able to run the project without issue is perhaps the easiest way to check on this, although, not sure whether that's more time consuming than checking all files or not.

There might be an update to the project repo soon which might make things easier for students and reviewers alike. Will update once that's ready and can then see if more information will be required or not around this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/udacity/robotics-beta-test-issues/issues/763#issuecomment-368058425, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNQuara761dLROD7-uR5yGAcFfvQTiqks5tXuW_gaJpZM4SRGrt .