udacity / robotics-nanodegree-issues

Public waffleboard to track Robotics Nanodegree Issues
2 stars 0 forks source link

Mistake on solution of Lesson1-21 of Controls #103

Closed estringana closed 7 years ago

estringana commented 7 years ago

Looking at the solution proposed, the following mistake was spotted

soln = hover(p)
cost = cost_fun(soln)
best_cost = cost

if cost < best_cost:

That condition will be never evaluated to true. However, the solution still works

thomas-at-em commented 7 years ago

You are absolutely right. Thanks very much for reporting! Should be fixed now.