search

udacity / robotics-nanodegree-issues

Public waffleboard to track Robotics Nanodegree Issues
2 stars 0 forks source link

control lesson 1: tuning strategies 2 #110

Closed lisajlau closed 7 years ago

lisajlau commented 7 years ago

in the solution.py, the cost is set to best_cost on line 139. I think this is an error, and should be removed. It is followed by an if statement that compares cost and best_cost, which would always return false line 139: best_cost = cost line 141: if cost < best_cost:

lisajlau commented 7 years ago

according to the image, it is set after the comparison has been done.

thomas-at-em commented 7 years ago

This was reported by another student. I believe it should be fixed now.