udacity / robotics-nanodegree-issues

Public waffleboard to track Robotics Nanodegree Issues
2 stars 0 forks source link

Fix training_helper.py glitches/crashing #112

Closed croomjm closed 6 years ago

croomjm commented 7 years ago

Master version of src/sensor_stick/training_helper.py has the following issues: 1) Object may not always be deleted between object types, so the new model may not get loaded. 2) Occasional crashes due to attempting to spawn new model with the same name before the old model has been deleted. 3) If the script is stopped with an interrupt, gazebo has to be rebooted to start capturing again since the script does not attempt to delete any remaining objects in the scene before starting.

I added the following lines before the assignment of 'spawn_model_prox", which seemed to solve most of the issues above: try: delete_model() except: print('No model to delete.')

kylesf commented 7 years ago

@hvpandya Thoughts on this?

hvpandya commented 7 years ago

I believe this script was written by @bkinman

bkinman commented 7 years ago

By adding more service calls we can fix all of the problems mentioned above. However, this would reduce the overall speed. One great way to fix this is by writing a gazebo plugin to assist us with the process of gathering training data.

It's not a bad idea to add the lines above... But I think that we need to write a gazebo plugin at some point.