I added pull request on Github to fix this - please check and accept!
The hover_twiddle_tuner_node claims to update kp, ki and kd params, but I noticed ki is never actually updated, even though the printout to screen claims it has. I noticed the problem is that the line that sets ki has been commented out. I discussed this with original author Brandon Kinman and he confirmed this was added for testing and should be fixed. So this pull request simply removes the comment and allows ki to be set correctly.
kylesf
commented
7 years ago
I added pull request on Github to fix this - please check and accept!
The hover_twiddle_tuner_node claims to update kp, ki and kd params, but I noticed ki is never actually updated, even though the printout to screen claims it has. I noticed the problem is that the line that sets ki has been commented out. I discussed this with original author Brandon Kinman and he confirmed this was added for testing and should be fixed. So this pull request simply removes the comment and allows ki to be set correctly.