search

udacity / ud851-Sunshine

Apache License 2.0
2k stars 4.5k forks source link

Misleading TODO text. #156

Open tuanlea opened 6 years ago

tuanlea commented 6 years ago

https://github.com/udacity/ud851-Sunshine/blob/6ca736c2395e1893e9dc82373141a38342e78238/S03.01-Exercise-RecyclerView/app/src/main/java/com/example/android/sunshine/MainActivity.java#L247

Please change the text to say "set the weather data to null". Setting the adapter to null would result in NPE when clicking on refresh.

croworc commented 6 years ago

Yep! :+1: However, this issue has already been reported with the following issue IDs:

19

93

116

121

138