udacity / ud851-Sunshine

Apache License 2.0
2k stars 4.51k forks source link

S12.01-Exercise-DimensionsColorsAndFonts #212

Open HasanElHefnawy opened 5 years ago

HasanElHefnawy commented 5 years ago

These entries were added in dimens.xml, but never used: today_icon list_item_icon_margin_end loading_indicator_size list_item_high_temperature_margin list_item_low_temperature_text_view_size

These entries have ambiguous names and need to be named clearly: forecast_temperature_space (should be named list_item_high_temperature_margin) forecast_text_size (should be named list_item_temperature_text_view_size)