search

udacity / ud892

MIT License
84 stars 425 forks source link

refactor to work with Gulp 4 #8

Open jkelley399 opened 5 years ago

jkelley399 commented 5 years ago

Based on https://www.sitepoint.com/automate-css-tasks-gulp/ https://gulpjs.com/docs/en/getting-started/quick-start https://gulpjs.com/docs/en/getting-started/creating-tasks https://gulpjs.com/docs/en/getting-started/async-completion consulted 2019-06-17 as well as the Udacity course materials https://classroom.udacity.com/nanodegrees/nd001/parts/20f5a632-38e6-48e7-88c8-e14c21590bb9/modules/de442af7-4ae2-48d7-a613-cf132eeaf60c/lessons/5831481034/concepts/55096392250923

jkelley399 commented 5 years ago

Please feel free (a) to ignore this PR entirely if it's not appropriate to the course content, and (b) to delete my INTRO comments if you want to use any of this. Thanks for reviewing this PR.

jkelley399 commented 5 years ago

Please note: although I modified gulpfile.js for Lesson 4, I believe that this approach should also address this issue 6, see, e.g., the 1/29/19 comment.

jkelley399 commented 5 years ago

I've gone ahead and made similar changes to Lesson 4 - Part 2 - Lesson 5, also noting (a) corresponding changes to package.json in that lesson and (b) potential future todo.

jkelley399 commented 5 years ago

And I've made corresponding changes to Lesson 4 - Part 2 - Lesson 6, Awesome Optimizations, again noting (a) corresponding changes to package.json in that lesson and (b) potential future todos.