search

udacityalumni / udacity-alumni-fe

A front-end web application and bespoke publishing platform, built by Udacity Alumni for Udacity Alumni
https://udacity-alumni.com
MIT License
46 stars 6 forks source link

Add footer to design #14

Closed RyanCCollins closed 8 years ago

RyanCCollins commented 8 years ago

We need to implement a sitewide footer component. (See below for a demo mockup)

RyanCCollins commented 8 years ago

I think this would be a great first feature for anyone looking to jump into the project. Here is an example mockup. Very simple!! The thing is, since this will be on the bottom of every single page, it needs to be a reusable component that has all of its features encapsulated. I don't see it needing much state, so it would be a component rather than a container.

To start with, however, you can try to do it on codepen first if you want. (Hint: Grommet has both a Footer component, as well as Icons for making buttons that link to our social accounts).

Also, I put some sample code that should help you get started in the repository: Here

Here is the mockup Mockup of Footer

kellim commented 8 years ago

I would like to try this one. I assigned it to myself.

RyanCCollins commented 8 years ago

Great! I think this is an awesome first step for you. I had talked to @martin-martin about doing it, but that;s okay I will communicate to him that he'll be doing something else. I think we can have some fun with this. Customizing the social icons, for example, could be fun. Let me know if you need some help. We could do that in a pairing session.

kellim commented 8 years ago

Thanks, I will try to figure it out on Codepen first, and I will let you know when I get stuck! Sorry @martin-martin. Also, should the social icons have links at this point, and if so should they link to the main Udacity social media pages?

forbiddenvoid commented 8 years ago

@kellim: For right now, yes those icons should link to those pages.

martin-martin commented 8 years ago

Haha! @kellim, no worries!!! I'm very happy that you decided to do this, I'm sure I'll find something else to do ; )

RyanCCollins commented 8 years ago

Note: there is now an app footer component that shows the text Udacity Alumni Web App. Please work off of this rather than the old component. Looking forward to seeing progress on this!

kellim commented 8 years ago

Got it. Do we want it to say "Udacity Alumni Web App"? Asking because it is not in the mock. And does the heart need to have a gradient or can it be the heart that is already in the text with a solid red color via css? Thanks!

kellim commented 8 years ago

I found the ❤️ but still need to know if we want to keep "Udacity Alumni Web App" in the footer.