udacityalumni / udacity-alumni-fe

A front-end web application and bespoke publishing platform, built by Udacity Alumni for Udacity Alumni
https://udacity-alumni.com
MIT License
46 stars 6 forks source link

Navigation Close Icon Expectations #166

Closed JamesIves closed 7 years ago

JamesIves commented 7 years ago

When the screen is within 720 and 860 pixels wide the navigation displays some strange behavior. Under 720 pixels if the burger icon is pressed the entire screen is taken up by the navigation, and in its place of the burger icon the close icon appears, which is good.

However between 720 and 860 the close button moves onto the actual pull-out menu its self, and the existing burger icon shifts to the other side of the screen, as a user this behavior likely would not feel expected. See the storyboard below:

Navigation Before

Navigation After

I propose making it so the burger icon is removed entirely, and allow users to click off the pull-out menu by selecting the body area to close it, but I'd like to hear what others think.

RyanCCollins commented 7 years ago

Yeah, that sounds like a good plan. Hide the burger menu and add a click handler to the document.body to close it. Is that something that you think you can implement?

JamesIves commented 7 years ago

On it