udalrich / jdibug

Automatically exported from code.google.com/p/jdibug
17 stars 4 forks source link

jdibug-connect can add nil to list of virtual machines #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to connect when there is no listening process
2. It will fail, but jdibug-virtual-machines will be the list(nil)

Here's a simple fix:  instead of using mapcar, use mapcan:

  (mapcan (lambda (connect-host-and-port)
                    (let* (...)
                          (jdibug-message (format "%s:%s" host port) t)
                          (condition-case err
                                  (progn
                                    (jdi-virtual-machine-connect vm)
                                    (jdibug-message "(connected)" t)
                                    (list vm))
                            (file-error (jdibug-message "(failed)" t) nil))))
                  jdibug-connect-hosts))

Original issue reported on code.google.com by lann...@gmail.com on 16 Sep 2010 at 4:45

GoogleCodeExporter commented 9 years ago

Original comment by udalrich.schermer on 5 Dec 2010 at 2:39

GoogleCodeExporter commented 9 years ago
Fixed in r416.  To be released as part of 0.4.

Original comment by udalrich.schermer on 5 Dec 2010 at 2:46

GoogleCodeExporter commented 9 years ago

Original comment by udalrich.schermer on 12 Apr 2011 at 3:28