search

udapi / udapi-python

Python framework for processing Universal Dependencies data
GNU General Public License v3.0
57 stars 31 forks source link

Corefhtml writer: use a relative docs_dir path in the JS script #120

Closed michnov closed 9 months ago

michnov commented 9 months ago

Issue description:

In the write.corefhtml package, the docs_dir parameter is supposed to contain a path relative to the directory where the HTML file is output. However, this is violated when the output directory is not the current working directory.

Fix description:

The fix introduces js_docs_dir which should always contain a relative path to be used in the JS scripts. On the other hand, if the output directory is specified using the path parameter, the docs_dir is adjusted so that it is relative to the output path.

TODO:

For the time being, it only works if the path parameter is specified. It is not adjusted if the output directory is specified using the files parameter.

martinpopel commented 9 months ago

Thanks a lot.