search

udark / underdark-android

Bluetooth peer-to-peer mesh networking for Android
http://underdark.io
Other
219 stars 56 forks source link

Update targetSDK, buildTools, support library and maven plugin #8

Open madlymad opened 7 years ago

madlymad commented 7 years ago

Note that during build a warning appeared.

Warning:The android.dexOptions.incremental property is deprecated and it has no effect on the build process.

virl commented 7 years ago

@madlymad targetSdkVersion 24 is not currently supported by sources, because it requires support for runtime app permissions.

madlymad commented 7 years ago

Thanks, Good to know that :+1:

madlymad commented 7 years ago

Do you have any problem on depending on an extra library for the permission handling or this just an issue you just not had time to look so far?

Generally there are a lot of libraries for this handling https://android-arsenal.com/tag/235.

I am asking because I want to test your library and if it helps the connectivity issue that I am trying to solve I'll added to one of my ongoing projects, so this will be one of my problems that either I have to workaround or implement in the library side.

Thanks for your time.

virl commented 7 years ago

@madlymad Currently I'm in the process of refactoring of entire Android library, mainly to improve connectivity logic and memory handling. I'm doing this refactoring on private repository, not on GitHub, because I decided to change business model to closed source (but binary version will be available for free anyway). Support for runtime permissions will be implemented at the end of that refactoring.

Generally I think that this networking library should not depend on any third-party permissions library, because different apps/users have different preferences for such permissions libraries and even can use another in their app already. Also such dependency can potentially make building of library more fragile.

Due to that this networking library should implement callback/listener api for requesting specific permissions that it needs from the app and hosting app itself should decide what library use to request these permissions. After they are granted/denied, it should notify networking library about it.

Faolain commented 3 years ago

@virl any updates on that refactor? It looks like the underdark domain is now offline so I'm curious what happened to this.