search

uday03meh / RockPaperScissors

A fun Rock Paper Scissors game to curb your boredom
https://uday03meh-rock-paper-scissors.netlify.app/
5 stars 24 forks source link

Adding attractive Header #49

Closed shrutigajbhiye22 closed 2 years ago

shrutigajbhiye22 commented 2 years ago

I would like to add attractive header to the page.

shrutigajbhiye22 commented 2 years ago

Hey @uday03meh ! I would like to work on this issue, could you please assign me this issue under the tag of hactoberfest?

uday03meh commented 2 years ago

Hi @shrutigajbhiye22 , Can you please share a screenshot of what you are planning to add before making a Pull Request?

shrutigajbhiye22 commented 2 years ago

I'm really sorry, but I realised that adding header won't look good. Really sorry for creating inappropriate issue :( and to compensate that I've made some changes, which you might like.

https://user-images.githubusercontent.com/96727722/197659319-531c9d61-43a4-4eb6-93e4-cc04f212094b.mp4

I have tried to make it look more neat and consistent and more aligned. Like, by adding space in Rock paper Scissor, increasing font size, increased space between buttons, changed colour of hovering effect on buttons, also changed colour of button to more go-to green colour.

Could you assign me this, under hactoberfest tag please?

uday03meh commented 2 years ago

Hey, it's alright. These changes look good in desktop mode, don't change the background colors of buttons or hovering effect but please make sure they are responsive as well before making a Pull Request.

shrutigajbhiye22 commented 2 years ago

Yeah it's responsive :) In fact it was a bug that the view was inconsistent in desktop mode.

uday03meh commented 2 years ago

Okay, you can create a Pull Request.

shrutigajbhiye22 commented 2 years ago

https://user-images.githubusercontent.com/96727722/197754923-5922006f-c773-4c46-a70c-b45a53ab46ef.mp4

How's this then?

shrutigajbhiye22 commented 2 years ago

Did you not merge it in your repo?

On Tue, Oct 25, 2022 at 8:08 PM Uday Mehtani @.***> wrote:

Closed #49 https://github.com/uday03meh/RockPaperScissors/issues/49 as completed.

— Reply to this email directly, view it on GitHub https://github.com/uday03meh/RockPaperScissors/issues/49#event-7664280800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXB7FKQIVC3HQHDUHEJFHYLWE7WHXANCNFSM6AAAAAARNL7TIA . You are receiving this because you were assigned.Message ID: @.***>

shrutigajbhiye22 commented 2 years ago

Sorry, hactoberfest showed not-accepted by maintainer till now. but now it's accepted. Sorry for the trouble and thank you!

On Tue, Oct 25, 2022 at 8:30 PM SHRUTI GAJBHIYE @.***> wrote:

Did you not merge it in your repo?

On Tue, Oct 25, 2022 at 8:08 PM Uday Mehtani @.***> wrote:

Closed #49 https://github.com/uday03meh/RockPaperScissors/issues/49 as completed.

— Reply to this email directly, view it on GitHub https://github.com/uday03meh/RockPaperScissors/issues/49#event-7664280800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXB7FKQIVC3HQHDUHEJFHYLWE7WHXANCNFSM6AAAAAARNL7TIA . You are receiving this because you were assigned.Message ID: @.***>

uday03meh commented 2 years ago

No worries :) Keep Contributing!