search

udayvunnam / xng-breadcrumb

A lightweight, configurable and reactive breadcrumbs for Angular 2+
https://udayvunnam.github.io/xng-breadcrumb
MIT License
242 stars 62 forks source link

Package "xng-breadcrumb" has an incompatible peer dependency to "@angular/platform-browser-dynamic" #118

Closed fgoulet closed 2 years ago

fgoulet commented 2 years ago

🐞 Bug report

Description

When I try to update my project from angular 13.1.0 to 13.1.1, I got this error:

Package "xng-breadcrumb" has an incompatible peer dependency to "@angular/platform-browser-dynamic" (requires "13.1.0" (extended), would install "13.1.1")

Would it be possible to update the peer dependencies of xng-breadcrumb ?

Thanks !

Angular Version:

13.1.1

github-actions[bot] commented 2 years ago

Hello 👋 @fgoulet
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

marvin-belonio commented 2 years ago

the dependency to angular should probably not be fixed to 13.1.0 but open to angular 13 so "^13.1.0"

udayvunnam commented 2 years ago

Whatever we specify in package.json will not end up in the final library when published.

But keeping ^ so it allows patch and minor versions is good practice. I will make this change

udayvunnam commented 2 years ago

@marvin-belonio and @fgoulet thanks for raising this issue, it's been fixed in xng-breadcrumb@7.2.0