Z-Index of the navbar is too much.

udecode / plate

Rich-text editor with shadcn/ui

https://platejs.org

Other

10.8k stars 665 forks source link

Z-Index of the navbar is too much. #3283

Closed hanzlah101 closed 2 months ago

hanzlah101 commented 3 months ago

Description

z-index of the navbar is too much. Every popover or dropdown just hides under it. Kindly fix this real quick.

Screenshot 2024-06-14 at 12 06 21 AM Screenshot 2024-06-14 at 12 07 48 AM

Reproduction URL

No response

Reproduction steps

Quick fix just adjust the z-index

Plate version

34.0.0

Slate React version

idk

Screenshots

No response

Logs

No response

Browsers

No response

Funding

You can sponsor this specific effort via a Polar.sh pledge below
We receive the pledge once the issue is completed & verified

12joan commented 3 months ago

One thing I do to prevent this from happening in my app is keep a comment in my main CSS file with the complete list of z-indices I'm using. Maybe we could adopt a similar pattern here.

/**
 * Z-index:
 *  5 - Focus ring
 * 10 - Fixed layout
 * 15 - Find dialog
 * 20 - Tippy
 * 30 - Modals
 * 40 - Tippy inside modal
 * 50 - Toasts
 */

zbeyens commented 3 months ago

Using css variables would be practical indeed.

yf-yang commented 3 months ago

60 is indeed too much.