search

udevbe / greenfield

HTML5 Wayland compositor :seedling:
GNU Affero General Public License v3.0
929 stars 29 forks source link

fix: clone over https #134

Closed jarrodcolburn closed 10 months ago

jarrodcolburn commented 10 months ago

Fix: use https to clone ffmpeg repo

Description:

Current libs/compositor-ffmpeg-h264/build_wasm.sh script uses ssh to git clone repo for ffmpeg.

However, many people (like me) building may be using a build environment without GitHub ssh setup. Attempting to clone GitHub repo without ssh keys setup results in the following error:

Cloning into 'ffmpeg'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

btw, I'm sorry to be opening such a pedantic PR, as I really appreciate all your hard work and think it's very cool what you're doing.

jarrodcolburn commented 10 months ago

btw, I'm still not sure this fixes my problem, as my build still fails

Zubnix commented 10 months ago

btw, I'm sorry to be opening such a pedantic PR, as I really appreciate all your hard work and think it's very cool what you're doing.

Don't! All PRs are welcome, even if they don't ultimately get merged!

Https is probably a better default for most people anyway 👍🏻

btw, I'm still not sure this fixes my problem, as my build still fails

If you have any more issues feel free to open an issue ticket. Happy to help you out.