search

udevbe / greenfield

HTML5 Wayland compositor :seedling:
GNU Affero General Public License v3.0
945 stars 29 forks source link

Question about fix_wrtc_native_module_require.patch #5

Closed markandrus closed 5 years ago

markandrus commented 5 years ago

Hi,

Can you please tell me why fix_wrtc_native_module_require.patch is required? It looks simple enough—perhaps we can land it in node-webrtc (with added support for Debug builds).

Mark

Zubnix commented 5 years ago

It has to do with the way https://github.com/zeit/pkg resolves the 'requires' statement. A lot of node native modules use node-cmake to simplify the finding of the native module. However the way node-cmake does it, breaks the final build when using zeit/pkg (as pkg has some kind of internal file system that does not match the node-cmake runtime resolution). Hence I created the patch(es).

So I'm not really sure if a change is really needed. I guess it would be nice, but in the end it's more of a node-cmake vs zeit/pkg module resolution issue.

markandrus commented 5 years ago

Hi, @Zubnix—as of wrtc@0.3.4, released today, I think the patch is no longer needed. The new version supports pkg.