Open zbraniecki opened 5 years ago
I experience a similar behaviour on the same hardware and OS. Maybe this snippet from dmesg is helpful. This block is printed out everytime I in/decrease brightness.
[68376.376526] ACPI BIOS Error (bug): Could not resolve symbol [\_SB.PCI0.PEG0.PEGP.BRT6.LCD], AE_NOT_FOUND (20190703/psargs-330)
[68376.376554] ACPI Error: Aborting method \_SB.PCI0.PEG0.PEGP.BRT6 due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
[68376.376991] ACPI Error: Aborting method \EV5 due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
[68376.377334] ACPI Error: Aborting method \SMEE due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
[68376.377537] ACPI Error: Aborting method \SMIE due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
[68376.377716] ACPI Error: Aborting method \NEVT due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
[68376.377871] ACPI Error: Aborting method \_SB.PCI0.LPCB.ECDV._Q66 due to previous error (AE_NOT_FOUND) (20190703/psparse-529)
I have the Dell 7590 and would love to see a picture of this. I am not sure if I see this issue or not. If I am seeing the issue... it would take a trained eye to see it. As for the ACPI issues above, I believe that is just a kernel/BIOS bug WRT to ACPI, and is known by the Linux kernel already.
As I am also on the 7590 I didn't want to open up a new thread. I started icc-brightness watch and was able to increase / decrease the brigthness. After like 10 miutes, i pressed again the buttons and nothing happened. In the console i can see this:
./icc-brightness watch profile object path '/org/freedesktop/ColorManager/profiles/icc_cb0062620d84fa82233e0c4d509347fc_al_1000' does not exist for this device ERROR: device-make-profile-default Traceback (most recent call last): File "./icc-brightness", line 136, in main icc_brightness_apply() File "./icc-brightness", line 108, in icc_brightness_apply icc_brightness(brightness, max_brightness) File "./icc-brightness", line 94, in icc_brightness get_device_id(), object_path], check=True) File "/usr/lib/python3.7/subprocess.py", line 512, in run output=stdout, stderr=stderr) subprocess.CalledProcessError: Command '['colormgr', 'device-make-profile-default', '/org/freedesktop/ColorManager/devices/xrandr_eDP_1_al_1000', '/org/freedesktop/ColorManager/profiles/icc_cb0062620d84fa82233e0c4d509347fc_al_1000']' returned non-zero exit status 1.
same problem as @paines. Also on Dell 7590
./icc-brightness apply
profile object path '/org/freedesktop/ColorManager/profiles/icc_189058f7fe0dc4e25e7f746926d3fe2f_adrianlyjak_1000' does not exist for this device
Traceback (most recent call last):
File "./icc-brightness", line 157, in <module>
main()
File "./icc-brightness", line 132, in main
icc_brightness_apply()
File "./icc-brightness", line 108, in icc_brightness_apply
icc_brightness(brightness, max_brightness)
File "./icc-brightness", line 94, in icc_brightness
get_device_id(), object_path], check=True)
File "/usr/lib/python3.6/subprocess.py", line 438, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['colormgr', 'device-make-profile-default', '/org/freedesktop/ColorManager/devices/xrandr_eDP_1_adrianlyjak_1000', '/org/freedesktop/ColorManager/profiles/icc_189058f7fe0dc4e25e7f746926d3fe2f_adrianlyjak_1000']' returned non-zero exit status 1.
Problem is intermittent, (only occurs for certain brightness steps). I can't find a pattern, the stops that work seem to change as I transition brightness up and down
I've got a Dell XPS 7590 with Fedora 30 / Wayland. Until some time ago icc-brightness worked for me fine and now suddenly it doesn't, can't figure out why. When I run watch manually I don't get any errors, the brightness just doesn't change. When I run clean it does remove the profiles, but again no change. This is with both the night light off and on.
Thanks guys for chiming in. I am running Debian Testing with Kernel 5.3. and without Wayland. Maybe it's an Kernel / ACPI thing ?
Am Di., 7. Jan. 2020 um 23:42 Uhr schrieb Mikuláš Poul < notifications@github.com>:
I've got a Dell XPS 7590 with Fedora 30 / Wayland. Until some time ago icc-brightness worked for me fine and now suddenly it doesn't, can't figure out why. When I run watch manually I don't get any errors, the brightness just doesn't change. When I run clean it does remove the profiles, but again no change. This is with both the night light off and on.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/udifuchs/icc-brightness/issues/16?email_source=notifications&email_token=AAK6EGT5M7GWPHFKDLTGSBDQ4UANFA5CNFSM4JLLYLT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIKRJQA#issuecomment-571806912, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK6EGSCNDNBD3ERHUYONT3Q4UANFANCNFSM4JLLYLTQ .
-- Herr / Mr. Anes Lihovac Email: anes.lihovac@gmail.com
Same laptop here and I have been running this since Fedora 30 (running 31 now). While it still works for me, it only increases brightness to about 50% now. I have to go into the settings (gnome) and pick the color profile with the highest brightness to get it to go over approximately 50%. I do get the same kernel messages about failure though. I have way more color profiles created than button presses though - I think this may have something to do with the 50%, but I am afraid if I "clean" them and start over, the kernel issue will keep it from working at all.
I run icc-brightness clean
and then immediately icc-brightness apply
to reset whenever the brightness settings start being ignored on my Thinkpad X1 Extreme (gen 2) with OLED.
I have the Dell 7590 and would love to see a picture of this. I am not sure if I see this issue or not. If I am seeing the issue... it would take a trained eye to see it. As for the ACPI issues above, I believe that is just a kernel/BIOS bug WRT to ACPI, and is known by the Linux kernel already.
Here's mine at night, ~20% brightness. XPS 9570 / Wayland / Ubuntu 18.04.
XPS 7590
I get same problem:
❯ icc-brightness watch
profile object path '/org/freedesktop/ColorManager/profiles/icc_3838ba26ddf77b01f82d1559480936e8_eleijonmarck_1000' does not exist for this device
ERROR: device-make-profile-default
Traceback (most recent call last):
File "/usr/local/bin/icc-brightness", line 136, in main
icc_brightness_apply()
File "/usr/local/bin/icc-brightness", line 108, in icc_brightness_apply
icc_brightness(brightness, max_brightness)
File "/usr/local/bin/icc-brightness", line 94, in icc_brightness
get_device_id(), object_path], check=True)
File "/usr/lib/python3.7/subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['colormgr', 'device-make-profile-default', '/org/freedesktop/ColorManager/devices/xrandr_eDP_1_1_eleijonmarck_1000', '/org/freedesktop/ColorManager/profiles/icc_3838ba26ddf77b01f82d1559480936e8_eleijonmarck_1000']' returned non-zero exit status 1.
I forked system76-oled and adapted it to work under Dell XPS 15 7590. You can find it here
@paines this is for X.org, right? I believe this repo is about Wayland.
Also, Dell is spelled as "Del" in the patch - one is wrong the patch, or their DMI.
:)
@gregoliver: Thanks for pointing out. Emacs ate that "l" for some reason. However I doubt the identifier does anything.
@Zibi Braniecki: I was not aware that this projet is about wayland, as it is no where mentioned at all. Anyway, thanks for pointing that out too.
Am Mo., 3. Feb. 2020 um 18:17 Uhr schrieb gregoliver < notifications@github.com>:
Also, Dell is spelled as "Del" in the patch - one is wrong the patch, or their DMI.
:)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/udifuchs/icc-brightness/issues/16?email_source=notifications&email_token=AAK6EGRUBUOVM4IYH5O4MCLRBBGRFA5CNFSM4JLLYLT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUU36A#issuecomment-581520888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK6EGRQ5CPUYZHSKWZX5H3RBBGRFANCNFSM4JLLYLTQ .
-- Herr / Mr. Anes Lihovac Email: anes.lihovac@gmail.com
I've the same issues too. But is seems that all the problems are related to the underlying colormgr (https://github.com/hughsie)
Running up to date Archlinux on a Dell XPS 7590, OLED 4K with Wayland (XOrg doesn't work too)
As you can see colormgr does not detect the monitor itself.
$ ./icc-brightness 50 100
Traceback (most recent call last):
File "./icc-brightness", line 157, in <module>
main()
File "./icc-brightness", line 150, in main
icc_brightness(brightness, max_brightness)
File "./icc-brightness", line 85, in icc_brightness
subprocess.check_output(['colormgr', 'import-profile', icc_filepath])
File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['colormgr', 'import-profile', '/tmp/brightness_50_100.icc']' returned non-zero exit status 1.
$ colormgr -v import-profile /tmp/brightness_50_100.icc
The profile was not added in time
$ colormgr get-devices
Object Path: /org/freedesktop/ColorManager/devices/cups_HP_Officejet_Pro_8600
Owner: root
Created: February 14 2020, 04:18:24 PM
Modified: February 14 2020, 04:18:24 PM
Type: printer
Enabled: Yes
Embedded: No
Model: HP Officejet Pro 8600
Vendor: Hewlett Packard
Serial: socket://192.168.179.142:9100
Format: ColorModel.MediaType.Resolution
Scope: temp
Colorspace: rgb
Device ID: cups-HP_Officejet_Pro_8600
Profile 1: HP_Officejet_Pro_8600-RGB..
Profile 2: HP_Officejet_Pro_8600-Gray..
Metadata: OwnerCmdline=/usr/bin/cupsd -l
Object Path: /org/freedesktop/ColorManager/devices/cups_Roger_Router_Fax
Owner: root
Created: February 14 2020, 04:18:24 PM
Modified: February 14 2020, 04:18:24 PM
Type: printer
Enabled: Yes
Embedded: No
Model: Generic PostScript
Vendor: Generic
Serial: socket://localhost:9100/
Format: ColorSpace.MediaType.Resolution
Scope: temp
Colorspace: rgb
Device ID: cups-Roger-Router-Fax
Profile 1: Roger-Router-Fax-RGB..
Profile 2: Roger-Router-Fax-Gray..
Metadata: OwnerCmdline=/usr/bin/cupsd -l
Object Path: /org/freedesktop/ColorManager/devices/cups_Kyocera_Kyocera_ECOSYS_M5526cdn_
Owner: root
Created: February 14 2020, 04:25:54 PM
Modified: February 14 2020, 04:25:54 PM
Type: printer
Enabled: Yes
Embedded: No
Model: Kyocera ECOSYS M5526cdn KPDL
Vendor: Kyocera
Serial: ipp://192.168.178.15/ipp
Format: ColorModel.MediaType.Resolution
Scope: temp
Colorspace: cmyk
Device ID: cups-Kyocera_Kyocera_ECOSYS_M5526cdn_
Profile 1: Kyocera_Kyocera_ECOSYS_M5526cdn_-CMYK..
Profile 2: Kyocera_Kyocera_ECOSYS_M5526cdn_-Gray..
Metadata: OwnerCmdline=/usr/bin/cupsd -l
Hmm, I'm getting different results:
▶ echo $XDG_SESSION_TYPE
wayland
~
▶ icc-brightness 50 100
~
▶ icc-brightness 60 100
~
▶ colormgr get-devices
Object Path: /org/freedesktop/ColorManager/devices/xrandr_eDP_1_zbraniecki_1000
Owner: zbraniecki
Created: February 13 2020, 07:59:35 PM
Modified: February 14 2020, 05:08:33 PM
Type: display
Enabled: Yes
Embedded: Yes
Model: XPS 15 7590
Vendor: Dell
Serial: unknown
Scope: temp
Colorspace: rgb
Device ID: xrandr-eDP-1
Profile 1: icc-256cc3ec12f0050db87329d2fa37d851
/home/zbraniecki/.local/share/icc/brightness_60_100.icc
Profile 2: icc-7ae9684e7ff9bf8a979b6571a3d06cce
/home/zbraniecki/.local/share/icc/brightness_50_100.icc
Profile 3: icc-2311af7ebbc9b71f89bbec4e60af29f0
/home/zbraniecki/.local/share/icc/brightness_66540_120000.icc
Profile 4: icc-dc5aa46aeecd0a220fd203b33a9b4f46
/home/zbraniecki/.local/share/icc/brightness_90300_120000.icc
Profile 5: icc-0a3026b7024004935b7c9cf363b9d74e
/home/zbraniecki/.local/share/icc/brightness_96240_120000.icc
Profile 6: icc-ccd7760e5a7390409015019c245e571d
/home/zbraniecki/.local/share/icc/brightness_102180_120000.icc
Profile 7: icc-30c0e440d8d3befb1d97018aeed9d7c0
/home/zbraniecki/.local/share/icc/brightness_84360_120000.icc
Profile 8: icc-cbc89b7d7b2c1b4e4d9d6efda02a7069
/home/zbraniecki/.local/share/icc/brightness_36840_120000.icc
Profile 9: icc-b414195b40fb2853a92e1484f7cc6196
/home/zbraniecki/.local/share/icc/brightness_30900_120000.icc
Profile 10: icc-3315804a83b12f2e2f2b490095f40dd6
/home/zbraniecki/.local/share/icc/brightness_24960_120000.icc
Profile 11: icc-2ccdedf61533eb3f4630c91905a84849
/home/zbraniecki/.local/share/icc/brightness_19020_120000.icc
Profile 12: icc-879f71768da7a7c6cafef0a4e606429c
/home/zbraniecki/.local/share/icc/brightness_13080_120000.icc
Profile 13: icc-40937de3e8de7225c6db508a8031f19b
/home/zbraniecki/.local/share/icc/brightness_7140_120000.icc
Profile 14: icc-a4002c3a61a7eb100a2046e3d896622d
/home/zbraniecki/.local/share/icc/brightness_1200_120000.icc
Profile 15: icc-05304498b0f6f9ce4693b36b199a1e8d
/home/zbraniecki/.local/share/icc/brightness_114060_120000.icc
Profile 16: icc-6d96db458aab1d0aae061cfb1b4eb9fa
/home/zbraniecki/.local/share/icc/brightness_120000_120000.icc
Profile 17: icc-d8c5514e5a6de76ac8812c415e6cce6d
/home/zbraniecki/.local/share/icc/brightness_116436_120000.icc
Profile 18: icc-9aa09ad3ec7d881e6c17835140c99d0b
/home/zbraniecki/.local/share/icc/brightness_104556_120000.icc
Profile 19: icc-06a35be8e7fde39738af232392b2c0a8
/home/zbraniecki/.local/share/icc/brightness_92676_120000.icc
Profile 20: icc-9d7358b0b6bf2bea51cf36087b7930b0
/home/zbraniecki/.local/share/icc/brightness_74856_120000.icc
Profile 21: icc-81e653f4fed3dd34841e54fecb48b820
/home/zbraniecki/.local/share/icc/brightness_62976_120000.icc
Profile 22: icc-7292c4cfcf8e9452a87758d60b2a9917
/home/zbraniecki/.local/share/icc/brightness_57036_120000.icc
Profile 23: icc-759a0dd8607e693246496241f82b5aff
/home/zbraniecki/.local/share/icc/brightness_51096_120000.icc
Profile 24: icc-2da13aed298f5e9b806d2cb33f89686a
/home/zbraniecki/.local/share/icc/brightness_45156_120000.icc
Profile 25: icc-8748dbf30dfc1a34b5c6178c1acf6990
/home/zbraniecki/.local/share/icc/brightness_39216_120000.icc
Profile 26: icc-fe3626f557a1ce6cade128f74e03b410
/home/zbraniecki/.local/share/icc/brightness_33276_120000.icc
Profile 27: icc-7f42e1a4675b40a492200782ef59a043
/home/zbraniecki/.local/share/icc/brightness_80796_120000.icc
Profile 28: icc-3b345d978a4db5444a9d96582b0aa66f
/home/zbraniecki/.local/share/icc/brightness_98616_120000.icc
Profile 29: icc-ec3c625e1ff4820da53f548b351bb70b
/home/zbraniecki/.local/share/icc/brightness_87924_120000.icc
Profile 30: icc-0636c19b18c82b06c6da152ce842354f
/home/zbraniecki/.local/share/icc/brightness_93864_120000.icc
Profile 31: icc-b5b1c94796a50a4e855a9ee62b229584
/home/zbraniecki/.local/share/icc/brightness_89112_120000.icc
Profile 32: icc-c627e09ae8d4d64c994508c13707305c
/home/zbraniecki/.local/share/icc/brightness_83172_120000.icc
Profile 33: icc-632e00d02d83e7c4d3e8aa59f0dff458
/home/zbraniecki/.local/share/icc/brightness_47532_120000.icc
Profile 34: icc-4afdaff0212520d2a46984242b8fa423
/home/zbraniecki/.local/share/icc/brightness_26148_120000.icc
Profile 35: icc-0a88cc2fbaad288475734523085fab47
/home/zbraniecki/.local/share/icc/brightness_27336_120000.icc
Profile 36: icc-8963c798bde2d30063e07e446fb16bf4
/home/zbraniecki/.local/share/icc/brightness_65352_120000.icc
Profile 37: icc-67e3f9681c8f3089326e2d7fbf2c28e2
/home/zbraniecki/.local/share/icc/brightness_30_100.icc
Profile 38: icc-fe1171e63770fcde1ae6a58a028b1131
/home/zbraniecki/.local/share/icc/brightness_20_100.icc
Profile 39: icc-8167c7746078ab3957ffb8f5921d67a4
/home/zbraniecki/.local/share/icc/brightness_40_100.icc
Profile 40: icc-724bba66fe418f8742b882fdf741ccdb
/home/zbraniecki/.local/share/icc/brightness_10_100.icc
Profile 41: icc-9012cd41c75da1cd8371b9d2c874ead8
/home/zbraniecki/.local/share/icc/edid-da69dc70fd7589ef396f6560e059ea39.icc
Metadata: OutputEdidMd5=da69dc70fd7589ef396f6560e059ea39
Metadata: OutputPriority=primary
Metadata: XRANDR_name=eDP-1
Metadata: OwnerCmdline=/usr/lib/gsd-color
(Arch linux up to date, Dell XPS 7590 OLED)
Are you sure running wayland? There's XRANDR mentioned.
I know... I think I am? I don't know how else to check it beyond
▶ echo $XDG_SESSION_TYPE
wayland
Hmmm, are you sure running wayland?
Beside echo $XDG_SESSION_TYPE wayland
there's XRANDR mentioned. And XRANDR is X11.
...
Object Path: /org/freedesktop/ColorManager/devices/xrandr_eDP_1_zbraniecki_1000
...
Metadata: XRANDR_name=eDP-1
...
(Sorry, re-posted because I re-checked it against X11)
yeah, so I don't know what is going on, just that brightness adjusting works for me? Is it possible that SESSION_TYPE is wayland and I am on X11 somehow? I'm on Gnome.
@Zibi Braniecki:
you could check with "loginctl"
output: SESSION UID USER SEAT TTY 2 1000 al seat0 tty2 c1 121 gdm seat0 tty1
then choose the id for your user, in this example it is "2"
loginctl show-session 2 -p Type
output: Type=x11 -> for me
Am Fr., 14. Feb. 2020 um 19:24 Uhr schrieb Zibi Braniecki < notifications@github.com>:
yeah, so I don't know what is going on, just that brightness adjusting works for me? Is it possible that SESSION_TYPE is wayland and I am on X11 somehow? I'm on Gnome.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/udifuchs/icc-brightness/issues/16?email_source=notifications&email_token=AAK6EGUNISW4TXRQD53ZSALRC3OVRA5CNFSM4JLLYLT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZ6V7I#issuecomment-586410749, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAK6EGXQCDG3T5Z4DCVDEG3RC3OVRANCNFSM4JLLYLTQ .
-- Herr / Mr. Anes Lihovac Email: anes.lihovac@gmail.com
I'm also having the same problem with certain brightness levels not working on this Dell. However, if I open up the color profiles menu under gnome-settings, I am able to manually select the levels that I can't get to with the brightness keys. Seems there's just a problem in the way this is telling colormgr to switch profiles.
▶ loginctl
SESSION UID USER SEAT TTY
2 1000 zbraniecki seat0 tty2
1 sessions listed.
~
▶ loginctl show-session 2 -p Type
Type=wayland
@uipoet approach worked for me. clean and then apply.
@uipoet approach also worked for me. Dell XPS 15 7590 4k oled + nvidia 1650, dual-booting windows 10 & ubuntu 19.10. Running icc-brightness clean
then icc-brightness apply
immediately solved the issue, and the brightness keys began working again. Note: I'm currently on the Nvidia Prime-Select profile Nvidia On-Demand.
Side Note: I still haven't solved the screen tearing that occurs when using the Nvidia 1650 card... I finally gave up and started using the "On-Demand" nvidia-settings profile mentioned above. It uses the Intel integrated graphics 99.99% of the time, forcing me to boot into Windows to do anything GPU-taxing. :/
If anyone solves that, you'll be my hero.
@johan-andersson01 For me this is an hardware issue with your OLED screen, Dell will change your unit, i receive a new one very soon. Test it on Windows, you will find out.
I have a Dell XPS 7390 (running Ubuntu 20.04 / X / i3) and I'm seeing the exact same issue. No matter what I do, colormgr
fails:
$ ./icc-brightness clean
$ ./icc-brightness apply
Traceback (most recent call last):
File "./icc-brightness", line 157, in <module>
main()
File "./icc-brightness", line 132, in main
icc_brightness_apply()
File "./icc-brightness", line 108, in icc_brightness_apply
icc_brightness(brightness, max_brightness)
File "./icc-brightness", line 85, in icc_brightness
subprocess.check_output(['colormgr', 'import-profile', icc_filepath])
File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/usr/lib/python3.8/subprocess.py", line 512, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['colormgr', 'import-profile', '/tmp/brightness_112872_120000.icc']' returned non-zero exit status 1.
When I run the above colormgr
command manually, I get:
$ colormgr import-profile /tmp/brightness_112872_120000.icc
The profile was not added in time
I installed arch linux with this package on Dell XPS 7590 OLED, and when I try to dim the screen I noticed two issues:
1) The brightness adapt correctly when operating in higher ranges - 50-100%. When operating in low light environment and trying to work between 10-50%, it does not dim the way MacBook Pro's Retina screen dims. It rather feels "burned out" - it does get darker, but still kind of "bright". I'm not very familiar with the color terminology, so not sure how to describe it, but it still feels very saturated and intense, compared to low brightness on Retina.
2) There's a weird light "bleeding" between 20-40%. When I set to 10%, it looks ok (minus what I wrote in (1)) - it's black background with white letters on a terminal. When I'm at 40%, it looks ok as well. But at 20% and 30% I see a gradual bright-to-dark from left to right which looks as if there was a light source bleeding from the left, in a radial shape. The closer to the right side of the screen the more black it is and close to it, it's full black. At 20% the radius is close to the middle of the screen, and the left side is fairly "bleeding light", while the right side is black, and at 30% 2/3 of the screen are bleeding, and the rightmost 1/3 is black.
Is that a shortcoming of this app, or the OLED/Wayland/Linux situation?