group moodle in jitsi

[atamabou]

Hello Sergio With appreciation from the OSS4SDG Hackathon “Get plugged into Education!”. This is the integration of moodle course groups in the jitsi plugin.

The invitation link is in some cases very important for teachers to facilitate meetings. Cordially

[SergioComeron]

Hi @atamabou First of all, thank you for the pull request to improve the plugin. I have been testing your plugin enhancement to integrate Moodle groups. I have seen some things that should be corrected to be able to integrate it:

• You are adding the invite button. In the plugin I'm hiding it because anyone who enters with that link would have moderation permissions and could even expel teachers. In addition, everyone who enters through that link will not see the button customizations that we have set by plugin configuration. Nor would it be recorded in the logs and attendance reports. The plugin has already implemented a functionality to be able to offer invitation links to a session and that should be used, since accessing from there if they have registration and moderation permissions are maintained.
• I believe that a teacher should be able to access the session of any group, regardless of the group they belong to.
• The group selector when belonging to multiple groups should be a bootstrap framework selector to match the aesthetics of Moodle.
• When you don't belong to any group, a notice appears if you have the debug activated.

The main problem I see is the theme of the invite button, I think if we remove that and do some tweaking we could integrate the improvement into the plugin.. Why did you include that button? Is it for some special reason?

[atamabou]

Hi @SergioComeron Thanks for the comments. I just fixed the errors seen with debugging. I think the rest is up to you for aesthetics. Regarding the invitation link I thought it was an oversight but actually it is not important since it is already taken into account otherwise. Regards

[atamabou]

Hello @SergioComeron I took into account all your comments:

• the shared link has been removed in accordance with what you say.

• course teachers can access any group's session, regardless of which group they belong to.

• The group selector is a bootstrap framework selector currently actually matching the aesthetics of Moodle.

• I did all of this with debug enabled and everything works fine. Also, I reduced the code as much as possible.

thank you so much.

[SergioComeron]

Thank you @atamabou! I'm reviewing your code more thoroughly and I think you are not using the groups api that moodle offers, right? You are making queries directly to the database.

[atamabou]

Hello @SergioComeron After a long search in the group API library, I didn't see a function that simply answers both queries. However, the syntaxes come from the group API library. I would propose to make it two functions in the jitsi library, one of which returns the course groups that teachers will access to the sessions and the other which returns the user groups in a course. Good for you.