search

udima-university / moodle-mod_jitsi

Plugin Jitsi viceoconference for Moodle
GNU General Public License v3.0
39 stars 36 forks source link

Allow users to open the conference in a seperate tab without iframe #78

Open henrybrink opened 3 years ago

henrybrink commented 3 years ago

Hello,

I and other students / teachers had some issues with the conference directly embedded into Moodle, sometimes it seems that the external API from Jitsi doesn't load completly and causes some issues (in most cases, the microphone is displayed as enabled while joining a muted conference and then can't be enabled / disabled). When the users open the link directly, theses issues are often resolved. This is likely an issue of Jitsi itself, but it could be useful to include a button which will directly open the conference in a new tab like it's done with the BigBlueButton module in Moodle.

The interface adjustements made by the plugin should still be possible, because Jitsi supports those parameters also via the URL (source: https://community.jitsi.org/t/how-to-how-to-customize-meeting-options/74665), the JWT-Token is also supported via the URL (source: https://github.com/jitsi/lib-jitsi-meet/blob/master/doc/tokens.md#jitsi-meet-options).

Such a setting could also be configured in the settings of the module, giving the admin the chance to decide whether such a button should be shown (maybe also with a third option which hides the option for the iframe).

If I'm seeing it correctly such a change could be implemented without too many efforts on the page the user see's before he is redicrected to the page with the iframe, If such a feature should be included I also would try to implement it.

And again thanks for the plugin, it really helps us during Covid...!

henrybrink commented 3 years ago

I tested a few things and the approach seems to work, all necessarry parameters are support via the url arguments. Should I create another pull request for this and close the other one because this also includes the setting for the avatars? I'm still not very experienced with the workflow of Pull Requests in GitHub.

Changes: https://github.com/henrybrink/moodle-mod_jitsi/tree/26a1416c337cdc99259af6e5001722b1c8ea8745

SergioComeron commented 3 years ago

I did some testing with this but couldn't get it to work properly. But this was a long time ago. Maybe now it will work. You should make a request just for this and another branch for the other problem. But do not worry, to test this code it works for me now. I hope I can test both for next week and introduce it for a new version.

henrybrink commented 3 years ago

Thank you! I first also encountered some issues, because some of the documentation of Jitsi was outdated or incorrect, also the URL caused some issues, but currently this way seems to work good as well.