udoklein / dcf77

Noise resilient DCF77 decoder library for Arduino
http://blog.blinkenlight.net/experiments/dcf77/dcf77-library/
GNU General Public License v3.0
93 stars 28 forks source link

missing weekday computation in adjust(...) #26

Closed udoklein closed 7 years ago

udoklein commented 7 years ago

Joachim Grimm reported, that void adjust(...) fails to recompute the weekday. The issue affects the examples simple_clock_with_timezone_support as well as the swiss_army_debug_helper.

udoklein commented 7 years ago

Three possible solutions:

1) assume weekday is correct and apply proper delta to it 2) convert time into internal format and let the library computer the weekday 3) directly compute the weekday from the date

I will ponder it a little more what would be the best approach.

udoklein commented 7 years ago

Fixed with this release: https://github.com/udoklein/dcf77/tree/v3.2.2 (commit 14c6389f4f8e594eee036f34bc85c29e889fbad2)

Jo-Achim commented 7 years ago

Thank you, Udo.