search

udoprog / audio

A crate for working with audio in Rust
Apache License 2.0
78 stars 11 forks source link

example does not build #2

Closed Be-ing closed 2 years ago

Be-ing commented 2 years ago 
audio on  main via 🦀 v1.58.0 
❯ cargo build
    Updating crates.io index
    Updating git repository `https://github.com/udoprog/minimp3-rs`
    Updating git submodule `https://github.com/lieff/minimp3.git`
    Updating git repository `https://github.com/udoprog/rubato`
error: no matching package named `audio` found
location searched: https://github.com/udoprog/rubato?branch=next#4ca6e6f9
required by package `rubato v0.9.0 (https://github.com/udoprog/rubato?branch=next#4ca6e6f9)`
    ... which satisfies git dependency `rubato` of package `examples v0.0.0 (/home/be/sw/audio/examples)`

The examples use your fork of rubato which uses relative filesystem paths for audio. While that may work on your machine, it does not work on mine. I recommend to use patch.crates-io in ~/.cargo/config.toml to work on libraries locally so you don't accidentally commit Cargo.toml in the repository with relative paths specific to your machine.

I see you have made some contributions to rubato but the branch used by the example uses a pretty big change that is not upstream nor do I see a PR for it upstream. Were you intending to make a PR for that upstream?

udoprog commented 2 years ago

Yeah. This is just for experimentation. I don't intend to submit anything upstream until this crate is done. I elaborated more in #3. But, we can certainly make it easier to build the rubato branch by not using relative paths!

udoprog commented 2 years ago

Example should now build, and they've been reconfigured so that they shouldn't break as easily. They now depend on the git version of the crate rather than a published one.