udoprog / c10t

A minecraft cartography tool
Other
225 stars 50 forks source link

Silent mode isn't completely silent #158

Closed mrphlip closed 13 years ago

mrphlip commented 13 years ago

The "Image limits" line is printed to std::cout, instead of out, so it shows up even in silent mode. Also, that line is missing an endl.

mrphlip commented 13 years ago
---
 src/main.cpp |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main.cpp b/src/main.cpp
index 19b393e..2006267 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -805,9 +805,9 @@ bool generate_map(settings_t &s, fs::path& world_path, fs::path& output_path) {
       out << "cache_hits: " << cache_hits << "/" << world_size << endl;
     }

-    std::cout << "image limits: "
+    out << "image limits: "
               << im_min_x << "x" << im_min_y << " "
-              << im_max_x << "x" << im_max_y;
+              << im_max_x << "x" << im_max_y << endl;

     image_ptr cropped = image::crop(work_in_progress, im_min_x, im_max_x, im_min_y, im_max_y);
     work_in_progress = cropped;
-- 
1.7.1

I wish there was an easier way to attach a patch to a bug than this...

mrphlip commented 13 years ago

Clearly I still don't know my way around github properly...

erisdev commented 13 years ago

The GitHub workflow with patches is fork it, fix it and send a pull request. Try it—it's pretty easy!

udoprog commented 13 years ago

mrphlip, either I could patch this manually, or you set up a pull request. The nice thing with a pull request is that your name will forever be ingrained in the patch history of the project.

Your pick : ).

uap-universe commented 13 years ago

This is pretty old, but fixed and therefore can be closed :)

udoprog commented 13 years ago

nice