search

udoprog / c10t

A minecraft cartography tool
Other
225 stars 50 forks source link

Wooden Slabs having the wrong color #177

Closed LaserPew closed 12 years ago

LaserPew commented 13 years ago

I think Wooden Slabs should have the same color as Wooden Planks. Is this a bug or done on purpose?

An example

OS: Linux x86_64 Version: git 043b30e, built on Jul 3 2011

uap-universe commented 13 years ago

This is because all the slabs have the same block id. For wool there is some code in c10t that should be modified to work with any other block as well. The color value should always depend on a combination of block id and damage value.

But this is a huge change - I don't know what udoprog's plans are.

HinchyMinecraft commented 13 years ago

I have a fork of c10t that I think I've added a fix for that too but I haven't been able to compile to test.

If someone wants to compile and test the source from https://github.com/zach-hinchy/c10t and it works okay (this is based off an older version though so no tall grass fix or pistons or etc, keep in mind) and I'll submit a pull request.

uap-universe commented 13 years ago

I try to have a look at this in the next few days. If you don't mind I would like to merge your changes into my colors branch and provide the pull request if everything is working. If it's not I'll try to provide the suitable fixes.

I'm very interested in how you solved this, but I currently don't have the time to watch it now.

uap-universe commented 13 years ago

Ok. I merged your fixes into my colors branch and everything is working fine. You can submit your pull request or wait for mine.

I'm currently working on #166. I hope I can fix this soon and then a pull request will contain the #166 and the #177 fix.