Refactor the terraform directory

udplabs / zartan

Zartan is a master of make-up and disguise and so is this demo.

GNU General Public License v3.0

23 stars 23 forks source link

Refactor the terraform directory #468

Closed noinarisak closed 2 years ago

noinarisak commented 2 years ago

Re-order the folder and file structure.
Add READMEs.
Support Terraform v1.1.x.
Add Makefile to help local development with HCL scripts and Zartan Verticals.
Improve readablity of HCL.

Resolves #345

noinarisak commented 2 years ago

@RyAndrew can you give this PR a try. There is a lot in this PR and want to make sure it works locally on someone else machine.

noinarisak commented 2 years ago

@RyAndrew any thoughts or issues with the PR?

RyAndrew commented 2 years ago

I'm about 80% done reviewing everything. Taking a very close look at things.

I ran through them all with the makefile and they ran correctly. I did have to create a developer.tfvars file

I noticed one spelling mistake: format("%s DEMO (Gerenated by UDP)", local.app_domain) Ge ren ated should be: Ge ner ated

noinarisak commented 2 years ago

I'm about 80% done reviewing everything. Taking a very close look at things.

I ran through them all with the makefile and they ran correctly. I did have to create a developer.tfvars file

I noticed one spelling mistake: format("%s DEMO (Gerenated by UDP)", local.app_domain) Ge ren ated should be: Ge ner ated

Awesome!