search

udvlpr / alembic

Automatically exported from code.google.com/p/alembic
Other
0 stars 0 forks source link

AbcView crashes if dolly speed exceeds threshold #324

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 

recording this bug for the record, and a reminder to fix this.

What steps will reproduce the problem?
1. abcview octopus.abc
2. Using alt+RMB, dolly the camera back and forth quickly

What is the expected output? What do you see instead?

AbcOpenGL::v1::GLCamera::dolly(const V2d&, double): Assertion `fabsf( dollyBy ) 
< 1.0' failed.
Abort (core dumped

What version of the product are you using? On what operating system?

Alembic 1.5.1
AbcView 1.0.5

Please provide any additional information below.

why does this assertion exist in GLCamera.cpp:242

assert( fabsf( dollyBy ) < 1.0 );

Original issue reported on code.google.com by r...@rsgalloway.com on 8 Nov 2013 at 11:45

GoogleCodeExporter commented 8 years ago 
Do things behave horribly if m_centerOfInterest grows too small?

The assert should definitely be removed, but does dollyBy need a reasonable cap?

Original comment by miller.lucas on 8 Nov 2013 at 11:53

GoogleCodeExporter commented 8 years ago 
Yep, pretty much. 

If it gets to about 0.1 you can't dolly anymore. this is easily tested in the 
console by reassigning the center value on the camera:

>>> self.viewer.camera.center = 0.1

Maybe I can fix with a min on the center of interest?

Original comment by r...@rsgalloway.com on 8 Nov 2013 at 11:58

GoogleCodeExporter commented 8 years ago 
That seems reasonable.

Original comment by miller.lucas on 9 Nov 2013 at 12:07

GoogleCodeExporter commented 8 years ago 
A fix for this assert (and another one I hit) is here:

http://code.google.com/r/millerlucas-dev/source/detail?r=5e112b510a2adb420bcd39b
4982f4b2075d0c7d2

Original comment by miller.lucas on 4 Dec 2013 at 10:11

GoogleCodeExporter commented 8 years ago 
Released in Alembic 1.5.2

Original comment by miller.lucas on 9 Dec 2013 at 6:54