ue4plugins / VlcMedia

Media Framework plug-in using the Video LAN Codec (libvlc).
BSD 3-Clause "New" or "Revised" License
267 stars 143 forks source link

Possible mistake in VLC init arguments #13

Closed KhArtNJava closed 8 years ago

KhArtNJava commented 8 years ago

Hello.

After https://github.com/ue4plugins/VlcMedia/issues/12 I commented

#if WITH_ENGINE
    //virtual void BindTexture(class FRHITexture* Texture) override;
    //virtual void UnbindTexture(class FRHITexture* Texture) override;
    virtual void BindTexture(class FRHITexture* Texture);
    virtual void UnbindTexture(class FRHITexture* Texture);

#endif

and successfully compiled project with your plugin. But with digging in your code I found interesting thing - in the file https://github.com/ue4plugins/VlcMedia/blob/master/Source/VlcMedia/Private/VlcMediaModule.cpp (line 86) this code:

"--vout", "dummy",

That's incorrect syntax of the arg - in the https://wiki.videolan.org/VLC_command-line_help: -V, --vout= Video output module This is the the video output method used by VLC. The default behavior is to automatically select the best method available.

You have missed symbol '=' in your code, it must be

"--vout=", "dummy",

But when I corrected it - after compilation and Editor re-launching, Editor starts with VLC(Direct3D9 output) window, that can't be closed (it's closing only when Editor closed): Image of Yaktocat

Do not be confused with this window - it's playing video with UE tutorial :) on this screenshot.

Is it really need to add "incorrect" (?) argument

"--vout", "dummy",

or not?

KhArtNJava commented 8 years ago

My mistake...